SonarSource Rules
  • Products

    In-IDE

    Code Quality and Security in your IDE with SonarQube Ide

    IDE extension that lets you fix coding issues before they exist!

    Discover SonarQube for IDE

    SaaS

    Code Quality and Security in the cloud with SonarQube Cloud

    Setup is effortless and analysis is automatic for most languages

    Discover SonarQube Cloud

    Self-Hosted

    Code Quality and Security Self-Hosted with SonarQube Server

    Fast, accurate analysis; enterprise scalability

    Discover SonarQube Server
  • SecretsSecrets
  • ABAPABAP
  • AnsibleAnsible
  • ApexApex
  • AzureResourceManagerAzureResourceManager
  • CC
  • C#C#
  • C++C++
  • CloudFormationCloudFormation
  • COBOLCOBOL
  • CSSCSS
  • DartDart
  • DockerDocker
  • FlexFlex
  • GitHub ActionsGitHub Actions
  • GoGo
  • HTMLHTML
  • JavaJava
  • JavaScriptJavaScript
  • JSONJSON
  • JCLJCL
  • KotlinKotlin
  • KubernetesKubernetes
  • Objective CObjective C
  • PHPPHP
  • PL/IPL/I
  • PL/SQLPL/SQL
  • PythonPython
  • RPGRPG
  • RubyRuby
  • RustRust
  • ScalaScala
  • SwiftSwift
  • TerraformTerraform
  • TextText
  • TypeScriptTypeScript
  • T-SQLT-SQL
  • VB.NETVB.NET
  • VB6VB6
  • XMLXML
  • YAMLYAML
C#

C# static code analysis

Unique rules to find Bugs, Vulnerabilities, Security Hotspots, and Code Smells in your C# code

  • All rules 493
  • Vulnerability46
  • Bug88
  • Security Hotspot24
  • Code Smell335

  • Quick Fix 61
 
Tags
    Impact
      Clean code attribute
        1. Using unsafe code blocks is security-sensitive

           Security Hotspot
        2. Not specifying a timeout for regular expressions is security-sensitive

           Security Hotspot
        3. Hard-coded secrets are security-sensitive

           Security Hotspot
        4. Constructing arguments of system commands from user input is security-sensitive

           Security Hotspot
        5. Deserializing objects without performing data validation is security-sensitive

           Security Hotspot
        6. Disabling ASP.NET "Request Validation" feature is security-sensitive

           Security Hotspot
        7. Allowing requests with excessive content length is security-sensitive

           Security Hotspot
        8. Using publicly writable directories is security-sensitive

           Security Hotspot
        9. Using clear-text protocols is security-sensitive

           Security Hotspot
        10. Having a permissive Cross-Origin Resource Sharing policy is security-sensitive

           Security Hotspot
        11. Expanding archive files without controlling resource consumption is security-sensitive

           Security Hotspot
        12. Configuring loggers is security-sensitive

           Security Hotspot
        13. Using weak hashing algorithms is security-sensitive

           Security Hotspot
        14. Delivering code in production with debug features activated is security-sensitive

           Security Hotspot
        15. Disabling CSRF protections is security-sensitive

           Security Hotspot
        16. Searching OS commands in PATH is security-sensitive

           Security Hotspot
        17. Creating cookies without the "HttpOnly" flag is security-sensitive

           Security Hotspot
        18. Setting loose file permissions is security-sensitive

           Security Hotspot
        19. Using non-standard cryptographic algorithms is security-sensitive

           Security Hotspot
        20. Using pseudorandom number generators (PRNGs) is security-sensitive

           Security Hotspot
        21. Creating cookies without the "secure" flag is security-sensitive

           Security Hotspot
        22. Formatting SQL queries is security-sensitive

           Security Hotspot
        23. Hard-coded credentials are security-sensitive

           Security Hotspot
        24. Using hardcoded IP addresses is security-sensitive

           Security Hotspot

        Having a permissive Cross-Origin Resource Sharing policy is security-sensitive

        intentionality - complete
        security
        Security Hotspot
        • cwe

        Having a permissive Cross-Origin Resource Sharing policy is security-sensitive. It has led in the past to the following vulnerabilities:

        • CVE-2018-0269
        • CVE-2017-14460

        Same origin policy in browsers prevents, by default and for security-reasons, a javascript frontend to perform a cross-origin HTTP request to a resource that has a different origin (domain, protocol, or port) from its own. The requested target can append additional HTTP headers in response, called CORS, that act like directives for the browser and change the access control policy / relax the same origin policy.

        Ask Yourself Whether

        • You don’t trust the origin specified, example: Access-Control-Allow-Origin: untrustedwebsite.com.
        • Access control policy is entirely disabled: Access-Control-Allow-Origin: *
        • Your access control policy is dynamically defined by a user-controlled input like origin header.

        There is a risk if you answered yes to any of those questions.

        Recommended Secure Coding Practices

        • The Access-Control-Allow-Origin header should be set only for a trusted origin and for specific resources.
        • Allow only selected, trusted domains in the Access-Control-Allow-Origin header. Prefer whitelisting domains over blacklisting or allowing any domain (do not use * wildcard nor blindly return the Origin header content without any checks).

        Sensitive Code Example

        ASP.NET Core MVC:

        [HttpGet]
        public string Get()
        {
            Response.Headers.Add("Access-Control-Allow-Origin", "*"); // Sensitive
            Response.Headers.Add(HeaderNames.AccessControlAllowOrigin, "*"); // Sensitive
        }
        
        public void ConfigureServices(IServiceCollection services)
        {
            services.AddCors(options =>
            {
                options.AddDefaultPolicy(builder =>
                {
                    builder.WithOrigins("*"); // Sensitive
                });
        
                options.AddPolicy(name: "EnableAllPolicy", builder =>
                {
                    builder.WithOrigins("*"); // Sensitive
                });
        
                options.AddPolicy(name: "OtherPolicy", builder =>
                {
                    builder.AllowAnyOrigin(); // Sensitive
                });
            });
        
            services.AddControllers();
        }
        

        ASP.NET MVC:

        public class HomeController : ApiController
        {
            public HttpResponseMessage Get()
            {
                var response = HttpContext.Current.Response;
        
                response.Headers.Add("Access-Control-Allow-Origin", "*"); // Sensitive
                response.Headers.Add(HeaderNames.AccessControlAllowOrigin, "*"); // Sensitive
                response.AppendHeader(HeaderNames.AccessControlAllowOrigin, "*"); // Sensitive
            }
        }
        
        [EnableCors(origins: "*", headers: "*", methods: "GET")] // Sensitive
        public HttpResponseMessage Get() => new HttpResponseMessage()
        {
            Content = new StringContent("content")
        };
        

        User-controlled origin:

        String origin = Request.Headers["Origin"];
        Response.Headers.Add("Access-Control-Allow-Origin", origin); // Sensitive
        

        Compliant Solution

        ASP.NET Core MVC:

        [HttpGet]
        public string Get()
        {
            Response.Headers.Add("Access-Control-Allow-Origin", "https://trustedwebsite.com"); // Safe
            Response.Headers.Add(HeaderNames.AccessControlAllowOrigin, "https://trustedwebsite.com"); // Safe
        }
        
        public void ConfigureServices(IServiceCollection services)
        {
            services.AddCors(options =>
            {
                options.AddDefaultPolicy(builder =>
                {
                    builder.WithOrigins("https://trustedwebsite.com", "https://anothertrustedwebsite.com"); // Safe
                });
        
                options.AddPolicy(name: "EnableAllPolicy", builder =>
                {
                    builder.WithOrigins("https://trustedwebsite.com"); // Safe
                });
            });
        
            services.AddControllers();
        }
        

        ASP.Net MVC:

        public class HomeController : ApiController
        {
            public HttpResponseMessage Get()
            {
                var response = HttpContext.Current.Response;
        
                response.Headers.Add("Access-Control-Allow-Origin", "https://trustedwebsite.com");
                response.Headers.Add(HeaderNames.AccessControlAllowOrigin, "https://trustedwebsite.com");
                response.AppendHeader(HeaderNames.AccessControlAllowOrigin, "https://trustedwebsite.com");
            }
        }
        
        [EnableCors(origins: "https://trustedwebsite.com", headers: "*", methods: "GET")]
        public HttpResponseMessage Get() => new HttpResponseMessage()
        {
            Content = new StringContent("content")
        };
        

        User-controlled origin validated with an allow-list:

        String origin = Request.Headers["Origin"];
        
        if (trustedOrigins.Contains(origin))
        {
            Response.Headers.Add("Access-Control-Allow-Origin", origin);
        }
        

        See

        • OWASP - Top 10 2021 Category A5 - Security Misconfiguration
        • OWASP - Top 10 2021 Category A7 - Identification and Authentication Failures
        • developer.mozilla.org - CORS
        • developer.mozilla.org - Same origin policy
        • OWASP - Top 10 2017 Category A6 - Security Misconfiguration
        • OWASP HTML5 Security Cheat Sheet - Cross Origin Resource Sharing
        • CWE - CWE-346 - Origin Validation Error
        • CWE - CWE-942 - Overly Permissive Cross-domain Whitelist
          Available In:
        • SonarQube IdeCatch issues on the fly,
          in your IDE
        • SonarQube CloudDetect issues in your GitHub, Azure DevOps Services, Bitbucket Cloud, GitLab repositories
        • SonarQube Community BuildAnalyze code in your
          on-premise CI
          Available Since
          9.1
        • SonarQube ServerAnalyze code in your
          on-premise CI
          Developer Edition
          Available Since
          9.1

        © 2008-2025 SonarSource SA. All rights reserved.

        Privacy Policy | Cookie Policy | Terms of Use